On Wed, 20 Jul 2022 15:15:14 GMT, Andy Goryachev <[email protected]> wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> File Size shows upto 1 decimal value
>
> src/java.desktop/share/classes/sun/swing/FilePane.java line 1192:
>
>> 1190: setIcon(icon);
>> 1191:
>> 1192: } else if (value instanceof Long len) {
>
> I think this code needs to be extracted into a function, and a unit test
> added. Testing with different sizes and supported locales - let's say en_IN
> (Asian group separator) and ja_JP or zh_CN (no plural forms).
JDK does not do unit tests in this way. There is no place to put it.
We do functional "system" level regression tests.
-------------
PR: https://git.openjdk.org/jdk/pull/9327
