On Fri, 15 Jul 2022 04:57:19 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org> wrote:
>> It was seen that some of the icons like disabled-selected:, rollover icons >> are not shown. >> Fixed to get the default selected icon and use that if in case the icon for >> that state is not set. > > Prasanta Sadhukhan has updated the pull request incrementally with one > additional commit since the last revision: > > Add test I tested your changes and they work correctly. I noticed that you're replacing the else statement that handles when model is NOT enabled and NOT selected. I thought replacing this with an if would leave out some edge cases, but your fallback icon code seems to cover it. Looks good to me as I don't see any other edge cases and the test works correctly. ------------- Marked as reviewed by dnguyen (Author). PR: https://git.openjdk.org/jdk/pull/9481
