On Fri, 17 Jun 2022 00:09:28 GMT, Sergey Bylokhov <s...@openjdk.org> wrote:

> The specification of the  ICC_ColorSpace.fromCIEXYZ method 
> [says](https://github.com/openjdk/jdk/blob/9d4b25e7888098a866ff980e37b8d16d456906d8/src/java.desktop/share/classes/java/awt/color/ICC_ColorSpace.java#L428):
> 
>> * This method transforms color values using relative colorimetry, as defined 
>> by the ICC Specification.
> 
> The LCMS plugin implementation expects the rendering intent in the first part 
> of transform:
> https://github.com/openjdk/jdk/blob/9d4b25e7888098a866ff980e37b8d16d456906d8/src/java.desktop/share/classes/sun/java2d/cmm/lcms/LCMSTransform.java#L116
> 
> But the ICC_ColorSpace.fromCIEXYZ pass "ICC_Profile.icRelativeColorimetric" 
> to the [second 
> ](https://github.com/openjdk/jdk/blob/9d4b25e7888098a866ff980e37b8d16d456906d8/src/java.desktop/share/classes/java/awt/color/ICC_ColorSpace.java#L534)
>  part of transform. 
> 
> Note that ICC_ColorSpace.toCIEXYZ has a similar [specification 
> ](https://github.com/openjdk/jdk/blob/9d4b25e7888098a866ff980e37b8d16d456906d8/src/java.desktop/share/classes/java/awt/color/ICC_ColorSpace.java#L288)is
>  implemented 
> [properly](https://github.com/openjdk/jdk/blob/9d4b25e7888098a866ff980e37b8d16d456906d8/src/java.desktop/share/classes/java/awt/color/ICC_ColorSpace.java#L391).

This pull request has now been integrated.

Changeset: 77398430
Author:    Sergey Bylokhov <s...@openjdk.org>
URL:       
https://git.openjdk.org/jdk/commit/77398430b5e13768cddd5f63e8fe9e53735bbea8
Stats:     102 lines in 2 files changed: 95 ins; 2 del; 5 mod

8288633: The ICC_ColorSpace.fromCIEXYZ method uses the wrong rendering intent

Reviewed-by: prr

-------------

PR: https://git.openjdk.org/jdk/pull/9194

Reply via email to