On Sat, 13 Aug 2022 06:09:33 GMT, Julian Waters <[email protected]> wrote:

> libsplashscreen uses the address of the WINAPI UpdateLayeredWindow in the 
> condition of an if block, which will always evaluate to true since the 
> address is never NULL. It is highly unlikely that this is intentional, and is 
> either a harmless mistake that is ultimately optimized out during compilation 
> at best, or an as of yet uncaught, but severe bug in the implementation that 
> fails to call UpdateLayeredWindow at worst. 
> 
> Note: As of now the change simply removes the reference, advice is 
> appreciated if the commit is incorrect and the affected site is actually 
> meant to be a call to UpdateLayeredWindow (as well as whatever parameters are 
> required)

I see, will change the issue to reflect that before integrating

-------------

PR: https://git.openjdk.org/jdk/pull/9866

Reply via email to