Re: RFR: 8291792: DefaultStyledDocument.setCharacterAttribute accepts negative length [v3]

[Tejesh R]

On Wed, 17 Aug 2022 07:02:23 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org> 
wrote:

>> Tejesh R has updated the pull request incrementally with two additional 
>> commits since the last revision:
>> 
>>  - Merge branch 'branch_8291792' of github.com:TejeshR13/jdk into 
>> branch_8291792
>>  - Moved test to test/jdk/javax/swing/DefaultStyledDocument
>
> src/java.desktop/share/classes/javax/swing/text/DefaultStyledDocument.java 
> line 500:
> 
>> 498:      */
>> 499:     public void setCharacterAttributes(int offset, int length, 
>> AttributeSet s, boolean replace) {
>> 500:         if (length <= 0) {
> 
> @param length the length &gt;= 0 javadoc should it not be then > 0 ?

Yeah, its should be > 0 in java doc. Will update it accordingly. Then should I 
raise a CSR......?

> test/jdk/javax/swing/JTextPane/DefaultStyledDocumentTest.java line 1:
> 
>> 1: /*
> 
> Guess it can be moved to test/jdk/javax/swing/text/DefaultStyledDocument/
> Also, rename it something like TestDocNegLenCharAttr or something similar.

Updated.

-------------

PR: https://git.openjdk.org/jdk/pull/9830