On Mon, 22 Aug 2022 22:32:50 GMT, Harshitha Onkar <[email protected]> wrote:
>> Additional position setting (TOP_LEFT_CORNER) and a method to obtain bounds
>> of test instruction frame are added to PassFailJFrame to handle positioning
>> of multiple test frames.
>>
>> In scenarios where multiple test windows might be present, the test windows
>> might overlap the instruction frame. In order to fix this TOP_LEFT_CORNER
>> position option is added that positions the test instruction frame at top
>> left corner with main test window below it.
>>
>> Additionally `getInstructionFrameBounds()` is added to obtain the position
>> and dimensions of test instruction frame.
>
> Harshitha Onkar has updated the pull request incrementally with one
> additional commit since the last revision:
>
> minor change to positionTestWindow javadoc
test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 268:
> 266: * is null, only the instruction frame is positioned according to
> 267: * {@code position} parameter. This method should be called before
> making
> 268: * the test window visible.
Since this condition is documented, should we also implement check to handle it
by calling isShowing() and throw some warning/exception if its visible.
We do the opposite for getLocationOnScreen() where we throw exception if the
compoment is not showing.
-------------
PR: https://git.openjdk.org/jdk/pull/9525
