On Wed, 24 Aug 2022 16:45:35 GMT, Abhishek Kumar <[email protected]> wrote:
>> JFileChooser - empty file size issue fixed.
>> For empty file, now the size 0 KB.
>> Manual Test Case "FileSizeCheck.java" created.
>
> Abhishek Kumar has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Updated as per review comments
Changes requested by aivanov (Reviewer).
src/java.desktop/share/classes/sun/swing/FilePane.java line 1199:
> 1197: } else if (value instanceof Long len) {
> 1198: /*
> 1199: * Code block is relevant to Linux.
Suggestion:
* This code block is relevant to Linux.
I feel that a determiner is missing here: _This_ or _The_. Any native English
speakers?
src/java.desktop/share/classes/sun/swing/FilePane.java line 1200:
> 1198: /*
> 1199: * Code block is relevant to Linux.
> 1200: * File size is display up to 1 decimal precision.
Suggestion:
* File size is displayed up to 1 decimal precision.
Sorry, I missed it yesterday when I added _“is”_.
src/java.desktop/share/classes/sun/swing/FilePane.java line 1201:
> 1199: * Code block is relevant to Linux.
> 1200: * File size is display up to 1 decimal precision.
> 1201: * Base-10 number system used for formatting file size
Suggestion:
* Base-10 number system is used for formatting file size
With explicit _“is”_, it sounds better to me.
src/java.desktop/share/classes/sun/swing/FilePane.java line 1269:
> 1267: * Returns the file size in one decimal precision.
> 1268: */
> 1269: private static double formatToDoubleValue(long fileSize) {
Suggestion:
/**
* Rounds a value to one decimal place. It's used to format
* file size similar to how it's formatted in file managers on Linux.
*
* @param len the file size to round to one decimal place
* @return file size rounded to one decimal place
*/
private static double roundToOneDecimalPlace(long fileSize) {
-------------
PR: https://git.openjdk.org/jdk/pull/9327
