On Mon, 22 Aug 2022 15:33:27 GMT, Alexey Ivanov <[email protected]> wrote:

>> @prrace 
>> 
>> } else if (len < 1024L) {
>> ...
>> } has been removed in previous commit. 
>> So if listViewWindowsStyle is false then the next else if will be executed 
>> i.e. <100L.
>
>> } else if (len < 1024L) { ... } has been removed in previous commit. So if 
>> listViewWindowsStyle is false then the next else if will be executed i.e. 
>> <100L.
> 
> For clarity, would it be better to separate the cases?
> 
> 
>                 if (listViewWindowsStyle) {
>                     if (len == 0) {
>                 } else {
>                     if (len < 100L) {
>                 }
> 
> 
> This would increase the indentation level, yet it would make the code 
> clearer. Now two independent conditions are chained.

@aivanov-jdk Comments and method name has been changed as suggested.

-------------

PR: https://git.openjdk.org/jdk/pull/9327

Reply via email to