On Thu, 25 Aug 2022 08:00:38 GMT, Prasanta Sadhukhan <[email protected]> 
wrote:

>> When comboBox have focus, pressing Alt+Down (or Up) should render the popup 
>> which is not happening for Aqua L&F.
>> 
>> Fix is to add toggleAction for Alt+Down/Up keys as has been done for 
>> [MetalLookAndFeel](https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/javax/swing/plaf/metal/MetalLookAndFeel.java#L912)
>> 
>> closed problemlisted test is used to check the fix.
>
> Prasanta Sadhukhan has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Fix as seen in native combobox

src/java.desktop/macosx/classes/com/apple/laf/AquaComboBoxUI.java line 587:

> 585: 
> 586:     @SuppressWarnings("serial") // anonymous class
> 587:     private final Action openPopupOrhighlightLast = new AbstractAction() 
> {

may be openPopupOrHighlightLast (uppercase H)?

src/java.desktop/macosx/classes/com/apple/laf/AquaComboBoxUI.java line 602:

> 600: 
> 601:     @SuppressWarnings("serial") // anonymous class
> 602:     private final Action openPopupOrhighlightFirst = new 
> AbstractAction() {

may be openPopupOrHighlightFirst (uppercase H)

-------------

PR: https://git.openjdk.org/jdk/pull/10014

Reply via email to