On Tue, 6 Sep 2022 11:14:49 GMT, Tejesh R <[email protected]> wrote:
>> JFileChooser.getSelectedFiles() failed to retrieve files with
>> multi-selection and double-click. This occurs when a single file is selected
>> then enable multi-selection then select the same file through mouse
>> double-click(Two file chooser dialogs used before and after multi-selection
>> enabled). SelectedFiles are updated when a change in files/directory
>> selection is done or when selection is made through keyboard selection. In
>> this case since a single file is selected before multi-selection is enabled
>> and same file is selected again without changing the selection
>> index/directory, leaving selected Files un-updated.
>> **Proposed Fix** : Whenever Multi-Selection is enabled check if any files
>> are selected, if yes update the selected Files of JFileChoooser.
>
> Tejesh R has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Updated based on review comments
src/java.desktop/share/classes/sun/swing/FilePane.java line 1772:
> 1770: } else {
> 1771:
> listSelectionModel.setSelectionMode(ListSelectionModel.SINGLE_SELECTION);
> 1772: clearSelection();
When we move from multi-selection enabled to disable. We are clearing the
selection and calling setSelectedFiles(null). Do we need to replicate similar
state update when we move from multi-selection disable to enable (clearing
selection and calling setSelectedFile(null))?
It looks like somewhere we are not clearing SelectedFile() and it is causing
this issue.
-------------
PR: https://git.openjdk.org/jdk/pull/9996
