On Tue, 6 Sep 2022 12:42:05 GMT, Magnus Ihse Bursie <[email protected]> wrote:
>> I ran `codespell` on the `src/java.desktop` directory, and accepted those >> changes where it indeed discovered real typos. >> >> I ignored typos in public methods and variables. Maybe they can be fixed >> later on without much fanfare, if they are in internal classes. Typos in >> exposed APIs are likely here to stay. >> >> I will update copyright years using a script before pushing (otherwise like >> every second change would be a copyright update, making reviewing much >> harder). >> >> The long term goal here is to make tooling support for running `codespell`. >> The trouble with automating this is of course all false positives. But >> before even trying to solve that issue, all true positives must be fixed. >> Hence this PR. > > Magnus Ihse Bursie has updated the pull request with a new target base due to > a merge or a rebase. The pull request now contains 46 commits: > > - Merge branch 'master' into typos-in-java.desktop > - Revert changes in libjpeg > - Revert changes in libfreetype > - Update src/java.desktop/windows/classes/sun/awt/windows/WPrinterJob.java > > Co-authored-by: Alexey Ivanov > <[email protected]> > - Update src/java.desktop/unix/classes/sun/awt/X11/XBaseMenuWindow.java > > Co-authored-by: Alexey Ivanov > <[email protected]> > - Update src/java.desktop/unix/classes/sun/awt/X11/XBaseMenuWindow.java > > Co-authored-by: Alexey Ivanov > <[email protected]> > - Update src/java.desktop/share/classes/sun/swing/SwingUtilities2.java > > Co-authored-by: Alexey Ivanov > <[email protected]> > - Update src/java.desktop/share/classes/sun/swing/SwingUtilities2.java > > Co-authored-by: Alexey Ivanov > <[email protected]> > - Update src/java.desktop/share/classes/sun/awt/image/ImagingLib.java > > Co-authored-by: Alexey Ivanov > <[email protected]> > - Update src/java.desktop/share/classes/sun/awt/image/ImagingLib.java > > Co-authored-by: Alexey Ivanov > <[email protected]> > - ... and 36 more: https://git.openjdk.org/jdk/compare/6a1e98cb...1ce28314 Is `src/java.desktop/share/native/libawt/awt/image/gif/gifdecoder.c` a third-party code? src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLLayer.m line 87: > 85: J2dTraceLn4(J2D_TRACE_VERBOSE, > 86: "MTLLayer.blitTexture: uninitialized (mtlc=%p, > javaLayer=%p, buffer=%p, device=%p)", self.ctx, > 87: self.javaLayer, self.buffer, ctx.device); Is this an intended change? Or does it come from a merge? May I suggest wrapping the line after the format string before `self.ctx`? It would make it easier to read. ------------- PR: https://git.openjdk.org/jdk/pull/8328
