On Tue, 20 Sep 2022 21:38:48 GMT, lawrence.andrews <d...@openjdk.org> wrote:
>> 1) Fixed Parse Exception by removing yesno >> test result: Error. Parse Exception: Arguments to `manual' option not >> supported: yesno >> 2) Throw jtreg.SkippedException when printer is not configured on the test >> host >> 3) Replaced Sysout & TestDialog with ManualTestFrame, which allows to the >> user to better decide test results and to take screen shot if test fails. >> >> @shurymury > > lawrence.andrews has updated the pull request incrementally with one > additional commit since the last revision: > > Removed @key printer keyword since this is a manual test Looks like concern related to jtreg.SkippedException and its probably solution captured at : https://github.com/openjdk/jdk/pull/8412#issuecomment-1113522265 Since updated test follows https://openjdk.org/jtreg/faq.html#what-if-a-test-does-not-apply-in-a-given-situation and test is able to run in an environment where printer is configured. And throws SkippedException with appropriate message when printer is not configured, change looks okay to me. But as captured at https://github.com/openjdk/jdk/pull/8412#issuecomment-1113522265, we may need to update PassFailJFrame to handle these manual test case scenarios and show UI message that test is not run because of bad environment. ------------- Marked as reviewed by jdv (Reviewer). PR: https://git.openjdk.org/jdk/pull/9865
