On Mon, 3 Oct 2022 22:02:28 GMT, Alisen Chung <[email protected]> wrote:
>> Harshitha Onkar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> removed redundant jtreg header
>
> src/java.desktop/share/classes/javax/swing/plaf/metal/MetalBorders.java line
> 255:
>
>> 253: * @return a {@code int} which is the rounded value of provided
>> number
>> 254: */
>> 255: private static int roundDown(double d)
>
> The name of this method is a bit misleading, the operation doesn't actually
> round down, but rounds the number normally except for the x.5 case right?
> Does this operation exist somewhere else?
Yes, that is correct. The method doc does clarify the purpose. But I see your
point - probably `roundOff()` would sound less ambiguous and neutral?
-------------
PR: https://git.openjdk.org/jdk/pull/10274
