So Magare (what is your actual name ?),
As admin for this list I saw your latest email but due to size etc it
was rejected by OpenJDK mail servers.
I don't think I can do anything about that. In fact it wasn't even a
patch. It was a full copy of a file.
And I believe you misunderstood that Alexey was quoting what you should
have sent in reply
to the person who is triaging your bug submission. NOT to be sent to
this list. Go look in your inbox+spam.
Regardless OpenJDK does not take patches in email.
They need to be github PRs *after* following process below.
Have you read the OpenJDK Developer's Guide ? https://openjdk.org/guide/
Start here https://openjdk.org/guide/#contributing-to-an-openjdk-project
and make sure to sign and return the OCA mentioned there.
The OCA must be accepted in order to take code from you.
Do you have a github account ? You'll need one and it'll have to be
linked to an approved OCA.
You can then submit a PR against https://github.com/openjdk/jdk
I can help you "sponsor" this change, but you need to absorb the process
and do the OCA first.
-phil.
On 10/10/22 2:03 PM, Aleksei Ivanov wrote:
Hi,
JDK-8294904 [1] was resolved as Incomplete because there's no sample
code which demonstrates the problem. A comment was added:
Mail to submitter:
=============
Please share standalone test case/ reproducible step/ scenario to
analyze the issue better.
I should have received an email with request for clarification.
I looked through the description but it's still unclear to me how to
reproduce the problem and how to incorporate the fix you're proposing
and what the fix is. If you could provide the test case and better yet
the fix along with a regression test, it would be greatly appreciated.
The fix in the form of the diff would also help.
--
Regards,
Alexey
[1] https://bugs.openjdk.org/browse/JDK-8294904
On 09/10/2022 15:57, magar...@gmail.com wrote:
Since I am new to this, and apologies for the broad email, could
someone explain the following for the corresponding bug (JDK-8294904)?
* This bug is listed as one for a generic OS, whereas I specified
Windows (I can confirm that it is Windows only).
* This bug is listed as "resolved" with an "incomplete resolution".
I did provide the full solution, so I am not sure what this
means. (Also, Oracle asked for a standalone test, which I also
provided over email)
And thanks.
*From:* Kevin Rushforth <kevin.rushfo...@oracle.com>
*Sent:* Friday, September 30, 2022 8:29 AM
*To:* magar...@gmail.com; client-libs-dev@openjdk.org;
core-libs-...@openjdk.org
*Subject:* Re: professional (24-bit) sampled audio support in the
Windows native implementation of libjsound
Java Sound is in the client-libs area. You can file the bug yourself
at https://bugreport.java.com/ if you like, or ask the sponsor of
your bug (when one steps forward) to do it.
If you want to contribute your fix, please see the contributing a
patch section [1] in the JDK Developers Guide for the next steps.
-- Kevin
[1] https://openjdk.org/guide/#i-have-a-patch-what-do-i-do
On 9/30/2022 4:33 AM, magar...@gmail.com wrote:
Would anyone want to sponsor the following simple bug fix?
- The purpose is to enable playback and recording of 24-bit
sampled audio on Windows. This is already supported on other
systems.
- There is no associated bug in the bug database. I noted it as
a "bug" as the code misunderstands the WAVE RIFF format standards.
- There will be two very small changes to one Windows native cpp
file under libjsound
- I have tested the changes on a jdk build of the latest code.
Also, please advise which of these two groups this belongs to:
client libs or core libs?
