On Fri, 7 Oct 2022 18:33:52 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:

> I do not think this makes a difference. Well, the first insertion does make a 
> difference: it changes the text component state so from left-to-right only to 
> bidirectional.
> 
> The following manipulations just add more Arabic text, so that the entire 
> text run is right-to-left.
> 
> You want to test the situation where the change from left-to-right to 
> bidirectional and component orientation occurs for the first time, and the 
> text is inserted in the middle of a text run, in the end of text. You should 
> probably, re-create `JTextArea` and `UndoManager` to test such scenarios.
> 
> You should also verify the result of undo. If you insert text by one 
> character, each undo should remove that character from the text.
> 
> If you don't test the result of undo, you don't know whether the text was 
> modified as expected or not.

Test updated to test insertion individually at end, middle and beginning and 
also test results of undo.

-------------

PR: https://git.openjdk.org/jdk/pull/10446

Reply via email to