On Tue, 11 Oct 2022 04:54:14 GMT, Tejesh R <[email protected]> wrote:
>> When a custom `FileView` is used and folder traversal is restricted to a
>> particular directory NPE occurs when user tries to traverse/select other
>> folders except traversable folder. This is caused because when user selects
>> folder other than traversable, the traversal is rejected and hence no file
>> is selected as `currentDirectory` of `JFileChooser`. When user tries to
>> access the restricted folder second time, previous selected file check is
>> failing because of NPE since `getFileChooser().getCurrentDirectory();` is
>> null. To fix the issue, NPE check is added.
>
> Tejesh R has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Updated based on review comments
Marked as reviewed by aivanov (Reviewer).
test/jdk/javax/swing/JFileChooser/FileViewNPETest.java line 77:
> 75: 3. Select the Documents folder again.
> 76: 4. If NullPointerException does not occurs in the step 3,
> 77: click Pass, otherwise the Test Fails.
Suggestion:
4. If NullPointerException does not occur in the step 3,
click Pass, otherwise the test fails automatically.
I guess this is better and has no grammar mistakes.
-------------
PR: https://git.openjdk.org/jdk/pull/10485
