> This automates the test added in #9327.
> 
> The test has a set of objects which store the size of the file and the 
> expected displayed size, the file name is generated automatically. The 
> pattern for the file names ensures the files are displayed in the expected 
> order up to and including gigabytes, 10 digits. I added more test cases that 
> the original test had to verify the displayed size is rounded up, an 
> automatic test can easily verify more rows than a human can.
> 
> The finds the **Details** button in the file chooser and clicks it, then it 
> finds the table, finds the row where the first file is displayed. The test 
> compares the size displayed in the table to the expected one. If it doesn't 
> match, an error is printed to `stderr`. All the file sizes are verified. The 
> first error message, if any, is thrown to fail the test.
> 
> The test passes with the fix for 
> [JDK-8288882](https://bugs.openjdk.org/browse/JDK-8288882) and fails without 
> it.

Alexey Ivanov has updated the pull request incrementally with four additional 
commits since the last revision:

 - Set the locale to US
 - Adjust wrapping for error message
 - Use local variable to store first error message
 - Shorter error message

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/10802/files
  - new: https://git.openjdk.org/jdk/pull/10802/files/1dc4e2b6..614b0977

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=10802&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=10802&range=00-01

  Stats: 10 lines in 1 file changed: 6 ins; 0 del; 4 mod
  Patch: https://git.openjdk.org/jdk/pull/10802.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/10802/head:pull/10802

PR: https://git.openjdk.org/jdk/pull/10802

Reply via email to