On Tue, 25 Oct 2022 10:40:05 GMT, Aleksey Shipilev <[email protected]> wrote:
> Fails like this: > > > * For target > support_native_java.desktop_libsplashscreen_splashscreen_impl.obj: > splashscreen_impl.c > c:\buildbot\worker\build-jdkx-windows\build\src\java.desktop\share\native\libsplashscreen\splashscreen_impl.c(443): > error C2220: the following warning is treated as an error > c:\buildbot\worker\build-jdkx-windows\build\src\java.desktop\share\native\libsplashscreen\splashscreen_impl.c(443): > warning C4018: '>': signed/unsigned mismatch > c:\buildbot\worker\build-jdkx-windows\build\src\java.desktop\share\native\libsplashscreen\splashscreen_impl.c(444): > warning C4018: '>': signed/unsigned mismatch > c:\buildbot\worker\build-jdkx-windows\build\src\java.desktop\share\native\libsplashscreen\splashscreen_impl.c(466): > warning C4018: '>': signed/unsigned mismatch > c:\buildbot\worker\build-jdkx-windows\build\src\java.desktop\share\native\libsplashscreen\splashscreen_impl.c(467): > warning C4018: '>': signed/unsigned mismatch > ``` > > I just added the disabled warning for that file. > > Additional testing: > - [x] Windows x86_32 release (now builds) > - [x] Windows x86_32 fastdebug (now builds) > - [x] Windows x86_32 slowdebug (now builds) This pull request has now been integrated. Changeset: 772be2e0 Author: Aleksey Shipilev <[email protected]> URL: https://git.openjdk.org/jdk/commit/772be2e02b7bb1089116c0debb514154489cfa81 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8295868: 32-bit Windows build failures after JDK-8294466 Reviewed-by: erikj ------------- PR: https://git.openjdk.org/jdk/pull/10848
