On Mon, 31 Oct 2022 07:48:38 GMT, Prasanta Sadhukhan <[email protected]> wrote:
>> The behavior of MatteBorder constructors taking Insets object as a parameter >> is undocumented. It would throw NPE if null object is passed to it, which >> should be documented in the spec. > > Prasanta Sadhukhan has updated the pull request incrementally with one > additional commit since the last revision: > > Rectify javadoc of more border classes/methods Before I can approve this PR, I would like to see the javadoc for border classes (those that are modified) updated so that all of them use *“Reinitializes”* as the first word in the description instead of *“Reinitialize”*, which aligns with [the javadoc style guide](https://www.oracle.com/technical-resources/articles/java/javadoc-tool.html#styleguide): > **Use 3rd person (descriptive) not 2nd person (prescriptive).** > > The description is in 3rd person declarative rather than 2nd person > imperative. > > Gets the label. *(preferred)* > > Get the label. (avoid) ------------- PR: https://git.openjdk.org/jdk/pull/10740
