On Wed, 2 Nov 2022 14:05:36 GMT, lawrence.andrews <d...@openjdk.org> wrote:
>> 8295707: Create a regression test for JDK-7184401 >> >> JDK-7184401 - JDk7u6 : Missing main menu bar in Netbeans after fix for >> 7162144 >> Above bug got introduced due to a fix for >> [JDK-7162144](https://bugs.openjdk.java.net/browse/JDK-7162144). >> The issue was observed on the netbeans UI. >> The test below recreates a standalone test to mimic the failure reported in >> Netbeans in [JDK-7184401](https://bugs.openjdk.java.net/browse/JDK-7184401) >> and verifies that it is working as expected after it got fixed via >> [JDK-7189350](https://bugs.openjdk.java.net/browse/JDK-7189350)) >> >> The Test attempts to reproduce specific behavior of NetBeans at the certain >> toolbar creation stage. Widgets are created on EDT; Another code posts some >> events to them on EDT; From another thread some code calls explicitly >> edt.interrupt(). >> Before this got fixed, events from a second code got lost. >> >> This review is for migrating tests from a closed test suite to open. >> Testing: >> 1.Tested the code on jdk7u6 to reproduce the issue - the UI hangs when run >> on this build. >> 2. Tested the code on jdk7u361 b01 to validate the fix - the test passed. >> 3.Mach5 Testing(40 times per platform) in macos x64, linux x64 and windows >> x64 - the .results are clean > > test/jdk/java/awt/EventDispatchThread/InterruptEDTTest.java line 86: > >> 84: ((sun.awt.SunToolkit) (Toolkit.getDefaultToolkit())).realSync(); >> 85: try { >> 86: EventQueue.invokeAndWait(() -> { > > This is duplicate code in Line# 67 to Line# 72. The intent was to ensure latest values are picked up, thereby ensuring the stability of the code. But I see the point that it does add value since there is not change in the frame position. Will remove it. ------------- PR: https://git.openjdk.org/jdk/pull/10784
