On Wed, 11 May 2022 12:49:34 GMT, Artem Semenov <aseme...@openjdk.org> wrote:
>> A11Y implementation on macOS has to directly call the >> 'JList.setSelectedIndex' method in order to request selection on an item >> (see 'CAccessibility.requestSelection'). The reason is that a11y API lacks >> appropriate method.There's only >> 'javax.accessibility.AccessibleSelection#addAccessibleSelection' which is >> mapped to 'javax.swing.JList#addSelectionInterval', it can not be used to >> set selected index. >> >> @forantar @azuev-java @mrserb please review. >> >> Please note that the new API allows you to implement a multiple selection in >> lists from the Java side, but I did not succeed in implementing it, because >> I could not determine the inclusion of the so-called "VoiceOver multiple >> selection mode". > > Artem Semenov has updated the pull request incrementally with one additional > commit since the last revision: > > We don't do @author tags in openjdk > Not 2022 ? src/java.desktop/share/classes/javax/swing/JList.java line 52: > 50: import java.io.Serial; > 51: import java.io.Serializable; > 52: import java.util.*; We are trying not to use wildcard imports - probably automatic optimization of the IDE did it? I am always turning it off or set margin so high it is not triggered on anything with less then 200 individual package imports. test/jdk/java/awt/a11y/AccessibleListTest.java line 29: > 27: * @bug 8271846 > 28: * @summary Test implementation of AccessibleList interface > 29: * @author artem.seme...@jetbrains.com We are not using author tags in tests either - but that's just a nitpick. ------------- PR: https://git.openjdk.org/jdk/pull/8578
