On Wed, 9 Nov 2022 15:03:08 GMT, lawrence.andrews <d...@openjdk.org> wrote:
>> Test intermittently fails in VM citing "Tree is not editing". Seems to be >> problem with mouse clicks not getting registered properly.. >> Similar test test/jdk/javax/swing/JTable/6263446/bug6263446.java is not >> affected, so made the test similar to it by using same safeguard using >> Robot.waitForIdle() and modifying clickpoint to tree cell midpoint. >> >> Several iterations of the test pass in the OCI VM and all other physical >> platforms (link in JBS) > > test/jdk/javax/swing/JTree/6263446/bug6263446.java line 184: > >> 182: >> 183: frame.getContentPane().add(tree); >> 184: frame.setAlwaysOnTop(true); > > Java doc says its better to check whether the platform supports this method > before calling it > https://docs.oracle.com/javase/7/docs/api/java/awt/Window.html#setAlwaysOnTop(boolean) it also says "If always-on-top mode isn't supported for this window or this window's toolkit does not support always-on-top windows, calling this method has no effect." and I dont see we check for the support in any of the swing tests, so I guess we are ok.. ------------- PR: https://git.openjdk.org/jdk/pull/11057