On Fri, 18 Nov 2022 20:27:09 GMT, Harshitha Onkar <hon...@openjdk.org> wrote:
>> This is an older test that failed intermittently but had a fix specifically >> for mac systems by adding key presses on mac only. This test still >> intermittently failed after this fix long ago and was problem listed. >> >> I ran this test 100 times on each OS after applying waitForIdle and delays >> between all key presses to match the delays previously present in the test. >> >> I also added a debug line and save and image of the failing window upon >> failure to better debug if/when the test ever fails again. The debug line is >> to check if the previous fix for mac is relevant in the failure. The image >> shows the status of the window and what is focused at the time of failure. > > test/jdk/java/awt/Focus/UnaccessibleChoice/AccessibleChoiceTest.java line 99: > >> 97: } >> 98: robot.waitForIdle(); >> 99: robot.delay(2000); > > Is such a large delay required here since `autoDelay` and `waitForIdle` are > also being called? I believe the proper amount is a delay of 1000. I can reduce this, but I thought it might be best to leave as much unchanged as possible. It does make sense to reduce it to 1000 if possible though. ------------- PR: https://git.openjdk.org/jdk/pull/11227
