On Wed, 23 Nov 2022 15:29:35 GMT, ravi gupta <d...@openjdk.org> wrote:
>> This testcase Verify the content changes of a TextField for the following
>> assertions.
>>
>> a. TextListener get invoked when the content of a TextField gets changed.
>> b. TextListener not get invoked during text selection or when Special keys
>> such as Function Keys are pressed.
>>
>>
>> Testing:
>> Tested using Mach5(20 times per platform) in macos,linux and windows and got
>> all pass.
>
> ravi gupta has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8297489: bug added
Tested on Mac 12 and Win10 locally, test works as expected. CI testing looks
good.
Minor changes suggested.
test/jdk/java/awt/event/ComponentEvent/TextFieldTextEventTest.java line 2:
> 1: /*
> 2: * Copyright (c) 2007, 2022, Oracle and/or its affiliates. All rights
> reserved.
If this is a newly created test, then the copyright should contain only the
present year.
test/jdk/java/awt/event/ComponentEvent/TextFieldTextEventTest.java line 22:
> 20: * or visit www.oracle.com if you need additional information or have any
> 21: * questions.
> 22: */
Minor nit: Please add a newline between copyright header and import statements.
test/jdk/java/awt/event/ComponentEvent/TextFieldTextEventTest.java line 136:
> 134: }
> 135:
> 136: private static void typeKey(int key) throws Exception {
`throws Exception` clause can be removed.
test/jdk/java/awt/event/ComponentEvent/TextFieldTextEventTest.java line 140:
> 138: robot.keyRelease(key);
> 139: }
> 140:
Minor nit: extra newline before closing brace can be removed.
-------------
Changes requested by honkar (Author).
PR: https://git.openjdk.org/jdk/pull/11326
