On Thu, 24 Nov 2022 08:57:45 GMT, Abhishek Kumar <[email protected]> wrote:

>> The Backspace key doesn't lead to parent directory of current directory for 
>> JFileChooser in GTK LAF. 
>> Added the lazy input value in `GTKLookandFeel` and fix is working fine.
>> 
>> Implemented a manual test to check BackSpace behavior for all installed LAF 
>> in Linux platform.
>> The test mentioned in 
>> [JDK-8078471](https://bugs.openjdk.org/browse/JDK-8078471) 
>> `javax/swing/JFileChooser/4150029/bug4150029.html` also working fine with 
>> GTK option (-client 
>> -Dswing.defaultlaf=com.sun.java.swing.plaf.gtk.GTKLookAndFeel).
>
> Abhishek Kumar has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Backspace at root level handled

`>` There is a mapping for squarebutton in skin.laf `<uiProperty 
name="squareButton" type="BOOLEAN" value="false"/>`.
> Setting it true is having similar effect in Nimbus LAF also. So, I think in 
> Nimbus LAF the squarebutton property is set through skin.laf file.

This mapping ""BACK_SPACE", "Go Up"," I guess has nothing to do with 
squarebutton property..Probably you are confusing it with your other fix?

> I tried implementing an automated test case but in GTK LAF the cursor is 
> focused on textfield and the backspace event is not triggered to change 
> directory.

You probably can do `requestFocusInWindow `to proper component...you can try to 
find the who has the focus by `getFocusOwner`() when you try to do manually 
BACKSPACE and try to set to that in automated test...

-------------

PR: https://git.openjdk.org/jdk/pull/11291

Reply via email to