On Fri, 25 Nov 2022 02:21:09 GMT, SWinxy <d...@openjdk.org> wrote: >> Sergey Bylokhov has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains four additional >> commits since the last revision: >> >> - Merge branch 'openjdk:master' into JDK-8296905 >> - Update AWTAccessor.java >> - Merge remote-tracking branch 'upstream/master' into JDK-8296905 >> - 8296905: Replace the native LCMS#getProfileID() method with the accessor > > src/java.desktop/share/classes/sun/java2d/cmm/lcms/LCMS.java line 59: > >> 57: if (p instanceof LCMSProfile) { >> 58: return (LCMSProfile)p; >> 59: } > > Would be a good time to > Suggestion: > > if (p instanceof LCMSProfile profile) { > return profile; > }
That change is possible but it will be better to do it as a separate cleanup. ------------- PR: https://git.openjdk.org/jdk/pull/11116