On Tue, 6 Dec 2022 11:59:17 GMT, Tejesh R <[email protected]> wrote: >> When `JFileChooser` uses custom `FileSystemView`, traversing to >> link/shortcut to a folder throw `InternalError java.lang.InternalError ` in >> Windows. The issue found out to be in BasicFileChooserUI class which was >> unable to resolve the link path during directory setting. The >> `UsesShellFolder` check expects the FileSystemView to be of >> WindowsFileSystemView, which fails when custom FileSystemView is used. >> The fix includes resolving the link folder when custom File System View is >> used and has manual test. (Fix is test in CI system and no regression >> caused). > > Tejesh R has updated the pull request incrementally with one additional > commit since the last revision: > > Updated based on review Comments
Verified the test. Looks good to me. test/jdk/javax/swing/JFileChooser/FileSystemView/CustomFSVLinkTest.java line 35: > 33: import java.util.Arrays; > 34: > 35: import javax.swing.*; The import's can be specific. ------------- Marked as reviewed by abhiscxk (Author). PR: https://git.openjdk.org/jdk/pull/11510
