On Sat, 10 Dec 2022 23:08:48 GMT, Rajat Mahajan <d...@openjdk.org> wrote:
>> Harshitha Onkar has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains ten commits: >> >> - minor changes >> - Merge branch 'master' into RefactorBorder_8294484 >> - Merge branch 'master' into RefactorBorder_8294484 >> - review changes >> - Refactoring changes >> - Merge branch 'master' into RefactorBorder_8294484 >> - revert MetalBorder changes >> - merge master >> - refactoring changes - initial commit > > src/java.desktop/share/classes/com/sun/java/swing/SwingUtilities3.java line > 174: > >> 172: >> 173: if (resetTransform) { >> 174: g2d.setTransform(new AffineTransform()); > > Can we keep the original comment about this: > /* Deactivate the HiDPI scaling transform, > * so we can do paint operations in the device > * pixel coordinate system instead of the logical coordinate > system. > */ I believe @rajamah meant to put this comment before resetting the transform to explain why it's done. https://github.com/openjdk/jdk/blob/9911405e543dbe07767808bad88534abbcc03c5a/src/java.desktop/share/classes/javax/swing/border/LineBorder.java#L165-L169 The original comment above for `resetTransform` variable could also be preserved, it explains why we don't reset the transform when shear and/or rotation are used. ------------- PR: https://git.openjdk.org/jdk/pull/11571