On Wed, 7 Dec 2022 10:25:31 GMT, Abhishek Kumar <[email protected]> wrote:
> In case of GTK LAF, the current selected element was not visible due to > arrowbutton is rendered in entire display area of Combobox. > > The proposed fix is to set the `squareButton `property of combobox to `false > `so that the arrowbutton didn't take entire combobox display area for > rendering. The `getMinimumSize `method is overridden in `SynthComboBoxUI `to > consider **arrowbutton insets** for combobox minimum size. > > The JCK tests mentioned in JBS seems fine with the fix. > An automated test case is implemented to test in Nimbus and GTK LAF. The text > color check is to ensure the current selected item is visible. > > When clientlibs tests are run with LAF set to Nimbus and GTK LAF, few test > failures observed. > > `javax/swing/JComboBox/4523758/bug4523758.java` test failed with current fix > in GTK LAF. > `open/test/jdk/javax/swing/JComboBox/TestComboBoxHeight.java` test passes if > run in GTK LAF with current fix. > > In Nimbus LAF, the failures before and after fix has no issues as such. > > Although CI jobs looks ok with tests run in their default set LAFs. This pull request has now been integrated. Changeset: c4449224 Author: Abhishek Kumar <[email protected]> Committer: Tejesh R <[email protected]> URL: https://git.openjdk.org/jdk/commit/c4449224bbb70d1a0256ebf19297450ab0f98d4b Stats: 182 lines in 5 files changed: 180 ins; 0 del; 2 mod 8218474: JComboBox display issue with GTKLookAndFeel Reviewed-by: tr, serb ------------- PR: https://git.openjdk.org/jdk/pull/11555
