On Mon, 16 Jan 2023 11:40:00 GMT, Alexey Ivanov <[email protected]> wrote:
> > Looks good to me. > > I doubt a separate test for this issue is worth it. This case is entirely > covered by the test in #11901 for > [JDK-8299522](https://bugs.openjdk.org/browse/JDK-8299522), which also > ensures the button text isn't empty. > > Adding 8300084 to the `@bug` tag in that test is enough. It was my [original > suggestion](https://github.com/openjdk/jdk/pull/11901#discussion_r1068659255): > > > Now you can fix this bug so that Aqua L&F doesn't return null and add that > > bugid to this test. Yeah, but since https://github.com/openjdk/jdk/pull/11901 handles only Approve button size except for Aqua L&F and this fix is only for Aqua L&F I thought it would be better to not to maintain any dependency between the test/bug (Though this bug was initiated as part of https://github.com/openjdk/jdk/pull/11901 fix). I hope maintaining simple test case for two bug would be fine. ------------- PR: https://git.openjdk.org/jdk/pull/12008
