On Tue, 17 Jan 2023 05:07:42 GMT, Tejesh R <t...@openjdk.org> wrote:

>> FileChooser Open/Approve button size is shown incorrectly when no Approve 
>> button text is set in `CUSTOM_DIALOG` type. Reason being that no default 
>> Approve Button text is returned during Dialog Type Property change. Since 
>> `null` is returned as Button string the Button size is incorrectly shown. 
>> The fix here addresses the issue by adding a default Approve Button Text 
>> when no text is set explicitly in case of `CUSTOM_DIALOG` type.
>> Automated test is attached which has been tested with multiple test runs.
>
> Tejesh R has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Tooltip and Mnemonic checks added to test

test/jdk/javax/swing/JFileChooser/CustomApproveButtonTest.java line 24:

> 22:  */
> 23: import java.awt.Component;
> 24: import java.awt.Container;

`awt` imports may not be required. I think you can remove them.

-------------

PR: https://git.openjdk.org/jdk/pull/11901

Reply via email to