On Tue, 11 Oct 2022 00:25:04 GMT, Damon Nguyen <dngu...@openjdk.org> wrote:
>>> > Can we move the test file to one directory back as we are doing it in >>> > swing test fix. Means moving the test to Multscreen folder, instead of >>> > MultiScreenLocationTest.....? >>> >>> I second this. The test can sit inside the Multiscreen folder without the >>> need for a subfolder to match the way new tests are added. >> >> I prefer leaving the test at its original location. It's not a new test, it >> has a history in CI. Although, if everyone else thinks the test should be >> moved up, it's okay with me. >> >> Previously, each test had its own folder. Now, we tend to use flatter >> structure. > >> > > Can we move the test file to one directory back as we are doing it in >> > > swing test fix. Means moving the test to Multscreen folder, instead of >> > > MultiScreenLocationTest.....? >> > >> > >> > I second this. The test can sit inside the Multiscreen folder without the >> > need for a subfolder to match the way new tests are added. >> >> I prefer leaving the test at its original location. It's not a new test, it >> has a history in CI. Although, if everyone else thinks the test should be >> moved up, it's okay with me. >> >> Previously, each test had its own folder. Now, we tend to use flatter >> structure. > > If that's the case, I have nothing else against keeping it in its current > location. I had the impression to update tests (such as syntax) as they're > updated, but I can understand why updating its location may be useful. @DamonGuy @jayathirthrao can you double check which part of the test fails? Does the Robot.mouseMove, Robot.getPixelColor, or Robot.getScreenCapture fail on your machine? ------------- PR: https://git.openjdk.org/jdk/pull/10363
