On Mon, 12 Dec 2022 13:06:09 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
>> Looks good to me.
>>
>> In the description above: “…invoked one per property…”, it shoud be “once”.
>>
>> I think there's room for improvement. However, this is an internal-only
>> class.
>
>> I think there's room for improvement. However, this is an internal-only
>> class.
>
> This is what I have in mind. The list of callbacks is inconsistent in how the
> method and conditions when it's called are listed. One of the list items has
> no ending punctuation. Some portions of text should use `<code>` or
> `{@code}`, or even
> [`<samp>`](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/samp).
>
> I think `<p>` should be added before this sentence, _“If an error results in
> parsing, a RuntimeException will be thrown.”_ The sentence itself requires
> re-writing: “If parsing results in an error…”
>
> Both `RuntimeException` and `toLowerCase` below should be in `{@code}`.
>
> The usage of `<code>` could be updated to `{@code}` which is the recommended
> way.
>
> What do you think?
I think a Reviewer needs to re-review before it asks for sponsoring.
@aivanov-jdk: re-approve changes?
-------------
PR: https://git.openjdk.org/jdk/pull/10975
