Re: RFR: 8081474: SwingWorker calls 'done' before the 'doInBackground' is finished [v5]

[Andrey Turbanov]

On Tue, 31 Jan 2023 08:54:39 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org> 
wrote:

>> SwingWorker done() method [spec 
>> ](https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/javax/swing/SwingWorker.java#L452)
>>  says "Executed on the Event Dispatch Thread after the doInBackground method 
>> is finished"
>> but there's no mechanism in place to honor that claim.
>> The 
>> [spec](https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/javax/swing/SwingWorker.java#L289)
>> also says the state should be DONE after doInBackground() returns which is 
>> also not done.
>> 
>> Modified the code to honour the specification.
>
> Prasanta Sadhukhan has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Set DONE state for cancel

test/jdk/javax/swing/SwingWorker/TestDoneBeforeDoInBackground.java line 34:

> 32: public class TestDoneBeforeDoInBackground {
> 33: 
> 34:     static boolean doInBackground =  false;

Suggestion:

    static boolean doInBackground = false;

-------------

PR: https://git.openjdk.org/jdk/pull/11940