On Wed, 25 Jan 2023 18:40:31 GMT, Phil Race <[email protected]> wrote:

>> Nikita Gubarkov has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Skip tests if required font is absent
>
> src/java.desktop/macosx/classes/sun/font/CCharToGlyphMapper.java line 92:
> 
>> 90: 
>> 91:     private static int unicodeToUnits(int unicode, int dstOffset, char[] 
>> dst) {
>> 92:         if (unicode >= 0x10000) {
> 
> Why can't you use public API that already does this ? [ 
> ](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/lang/Character.html#toChars(int,char%5B%5D,int))
>  ?

Which API exactly? I didn't know there is any, so I added this as a helper 
method.

-------------

PR: https://git.openjdk.org/jdk/pull/4798

Reply via email to