On Thu, 12 Jan 2023 06:14:32 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org> wrote:
>> Spec for >> [MetalLookAndFeel](https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/javax/swing/plaf/metal/MetalLookAndFeel.java#L247) >> says: >> "...MetalLookAndFeel registers an entry for each of the classes >> in the package javax.swing.plaf.metal that are named MetalXXXUI. >> The string XXX is one of Swing's uiClassIDs. For the uiClassIDs >> that do not have a class in metal, the corresponding class in >> javax.swing.plaf.basic is used. For example, metal does not >> have a class named "MetalColorChooserUI", as such, >> javax.swing.plaf.basic.BasicColorChooserUI is used". >> >> There is class MetalMenuBarUI, but the method populates given defaults table >> with the value >> "javax.swing.plaf.basic.BasicMenuBarUI". >> >> Added entry for MetalMenuBarUI.. >> CI tests including JCK tests are ok. > > Prasanta Sadhukhan has updated the pull request incrementally with one > additional commit since the last revision: > > Update spec wording These words - "This class is only appropriate for Ocean. The spec needs to be updated to mention this." WHY can no other Theme use it ? Is there a reason ? I think the comment does not have enough backing explanation to be simply followed blindly. ------------- PR: https://git.openjdk.org/jdk/pull/11646
