On Fri, 3 Feb 2023 04:26:39 GMT, Prasanta Sadhukhan <[email protected]>
wrote:
>> test/jdk/javax/swing/JFileChooser/JFileChooserFontReset.java line 58:
>>
>>> 56: SwingUtilities.updateComponentTreeUI(fc);
>>> 57: System.out.println("Nimbus font " + fc.getFont());
>>> 58: SwingUtilities.invokeAndWait(() -> setLookAndFeel(laf));
>>
>> This will test the uninstallDefaults for the Nimbus only. I think you need
>> to iterate all L&F twice and for the different ones check that the font will
>> be changed(if L&Fs use different fonts).
>
> It tests for Nimbus as the fix is for that only.
> It tests transition from
> Metal/Motif/Windows/WIndowsClassis->Nimbus->Metal/Motif/Windows/WindowsClassis
> for windows platform, say.
> We can enhance the test to test other L&F uninstallDefaults as part of test
> enhancement exercise in a separate JBS, which I dont think is needed for this
> nimbus JBS fix.
> I hope it should not be a problem and should not be a blocker for this fix
> approval..
We should test that implementations of uninstallDefaults in other L&F do not
have the same bug, this version always check the same uninstallDefaults in
Nimbus only?
-------------
PR: https://git.openjdk.org/jdk/pull/12180
