On Mon, 13 Mar 2023 22:27:51 GMT, Sergey Bylokhov <[email protected]> wrote:

> It is probably better to integrate this "clear" operation into the peer 
> and/or repaintmanager, and exclude it in this method.

Are you sure? (Or alternatively: maybe I don't understand what you mean?)

By "clear operation" I assume you're referring to the call in Window.java 
`gg2dfillRect`. This clear logic has existed since 2009, so I'm reluctant to 
remove it. (And if we remove it: we can just remove the entire 
`paint(Graphics)` method, because that's the only reason it's overridden, 
right?)

Here's a screenshot of the code in question & a little git annotation:
<img width="1316" alt="image" 
src="https://user-images.githubusercontent.com/7669569/224851605-e697e698-c4ee-439e-9e04-6b41659a12f4.png";>

If you still want me to try to migrate this logic: can you give me an example 
of which classes you'd recommend trying to move it to?

-------------

PR: https://git.openjdk.org/jdk/pull/12993

Reply via email to