On Tue, 21 Mar 2023 17:57:17 GMT, Sergey Bylokhov <[email protected]> wrote:
>> test/jdk/javax/swing/text/html/CSS/CSSAttributeComplianceTest.java line 32:
>>
>>> 30: import javax.swing.text.html.CSS.Attribute;
>>> 31:
>>> 32: public class CSSAttributeComplianceTest{
>>
>> Suggestion:
>>
>> public class CSSAttributeComplianceTest {
>>
>>
>> There's a missing space before the opening brace.
>>
>> I wonder whether the test is supposed to be extendable… I mean with other
>> attributes. If it's the case, then the suggested name is fine. If it's only
>> for `background-position` attribute, then `BackgroundPositionAttributeTest`
>> could be a better alternative. (The `CSS` part is in the path, so I decided
>> to drop it from the class name.)
>
> Can we check that this default value will be parsed fine by some of our html
> component?
Yes, we can extend the test in future, most probably for TEXT_DECORATION so I
will keep the name same
The parsing expects the value to be in form of "% %" as can be seen here which
also does the parsing and there's no regression observed in client tests
https://github.com/openjdk/jdk/blob/91f407d6fe285c44bcc25c1acdf5dc0c43be0172/src/java.desktop/share/classes/javax/swing/text/html/CSS.java#L2687-L2709
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13114#discussion_r1145619337
