On Fri, 31 Mar 2023 09:11:20 GMT, Dmitry Cherepanov <[email protected]> wrote:
> Please review this PR which suggests to skip updateIconImages() for not yet > visible windows. The displayChanged notification can be sent to a window that > is in the process of initiailization and calling updateIconImages() may lead > to the deadlock. > > Testing: the deadlock no longer happens with this patch. The reg test for > JDK-8276849 works (window icon is updated after changing DPI settings). that's a good point. If the window is created and later iconifiied (for example) and then this notification comes in, will it be missed ? ------------- Changes requested by prr (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/13263#pullrequestreview-1367452061
