On Fri, 7 Apr 2023 17:03:56 GMT, Damon Nguyen <[email protected]> wrote:
>> Jeremy has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> 8303950: adding unit test for legacy window behavior
>>
>> This test passes in the current JDK. The test criteria don't really
>> reflect a rational expected behavior; they just reflect the current status
>> quo.
>>
>> This currently fails in this JDK-8303950 branch (using the new proposed
>> AWTPaintManager), which indicates we've changed behavior.
>>
>> In this case it's "window 4" that's failing. We used to get a mostly blue
>> background, and now we're getting a background that's mostly red with a
>> little blue. This isn't necessarily a bad thing; this failure is just
>> documenting a change.
>
> src/java.desktop/share/classes/java/awt/Window.java line 3953:
>
>> 3951: if (gg instanceof Graphics2D) {
>> 3952: gg.setColor(getBackground());
>> 3953: ((Graphics2D)
>> gg).setComposite(AlphaComposite.getInstance(AlphaComposite.SRC));
>
> Why was the import for SunHints added if the only edit to this file was
> adding a space?
Nevermind I saw this wrong when looking through the commit history.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/12993#discussion_r1160887595
