On Mon, 10 Apr 2023 21:32:30 GMT, Rajat Mahajan <[email protected]> wrote:
> **Problem:** > > On pressing the Copy button we keep waiting in AWT-EventQueue thread in > reconstruct() function as we detect that we have missing information for the > animated image since we are copying single frame at a time. > Due to this infinite wait the application freezes. > > **Proposed Fix:** > > There are conditions in the reconstruct() function that avoid entering the > wait() code if we have some error reading the image , etc. So, I added the > condition to avoid entering the wait() code if we are copying single frame at > a time. This sounded logical to me since if we have incomplete > information(single frame) about the animated image we shouldn’t keep waiting, > as it leads to infinite wait. > After this change I see the GIF image being correctly copied and animated. > > > **Testing:** > > Added a test for this (bug6176679.java) and tested locally on my Windows > machine and on mach5. Instead of using .gif image as input, its better if we can create ImageStream as we do in some of animation tests under test/jdk/javax/imageio/plugins/gif. ------------- Changes requested by jdv (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/13414#pullrequestreview-1380444337
