On Fri, 7 Apr 2023 01:45:01 GMT, Phil Race <[email protected]> wrote: >> Roger Riggs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update copyright >> Replaced a few more uses of os.name. > > So if we want to get rid of all the getProperty (etc) calls and unify it then > the way I'd prefer to do this is via a single channel inside the desktop > module. > So change everything to use that pre-existing sun.awt.OSInfo class. > Modifying that as necessary. Then that class can be the SINGLE place that has > a direct dependency on this java.base internal and we can more easily drop it > if required. > Meanwhile I also think there's a better than 50:50 chance someone will add > new uses of System.getProperty .. whatever the solution is. So > whack-a-mole-away.
@prrace Please review ------------- PR Comment: https://git.openjdk.org/jdk/pull/13213#issuecomment-1507561152
