On Sat, 22 Apr 2023 00:21:06 GMT, Alexander Zuev <[email protected]> wrote:

>> Cleaned up and stabilized four Dialog-related tests.
>
> Alexander Zuev has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Added couple of empty lines to make code nore readable.

test/jdk/java/awt/Dialog/DialogLocationTest.java line 175:

> 173:             test.start();
> 174:         } finally {
> 175:             EventQueue.invokeLater(() -> {

invokeLater may not be executed before the test stops by the jtreg, EDT could 
be killed at that point. It is better to use invokeAndWait or somehow make sure 
it will ends.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13592#discussion_r1175658476

Reply via email to