On Tue, 25 Apr 2023 22:46:57 GMT, Phil Race <[email protected]> wrote:
>> Martin Desruisseaux has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update documentation for adressing comment on pull requests, with two
>> changes to be discussed:
>>
>> - The "The default implementation" sentence has not yet been removed, for
>> reason discussed on the pull request.
>> - The discussion about (0,0) tile indices mentions the relationship with
>> `getTileMinX()` and `getTileMinY()`.
>
> src/java.desktop/share/classes/java/awt/image/BufferedImage.java line 1593:
>
>> 1591: * Since a {@code BufferedImage} consists of a single tile,
>> 1592: * and that tile is always checked out for writing, the
>> 1593: * default implementation returns an array of one point.
>
> I'd be happier with "the default implementation" -> "this method".
> I did read your notes on subclasses etc but really these methods should have
> been final so I'd like to make
> the documentation reflect that rather than implying that there's an open door
> to do something else.
Replaced all "The default implementation" texts by "This method". But if the
intend was to disallow alternative behaviour, maybe instead of making those
method final, `BufferedImage` should have simply not implemented
`WritableRenderedImage` and implement `RenderedImage` instead?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13506#discussion_r1179121544
