On Tue, 2 May 2023 11:10:14 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org> wrote:
> > The change looks good but it doesn't address the whole problem raised in > > the [JDK-7083187](https://bugs.openjdk.org/browse/JDK-7083187): > > `CSS.CssValue` does not implement `equals`. This fix addresses only one > > particular case: `CSS.FontSize` for `font-size` property. > > I do not think it resolves the problem _entirely_: `CssValue` and all its > > subclasses must implement `equals` method, otherwise adding another CSS > > attribute to `AttributeSet` will lead to this same issue described in the > > bug report. > > Yes, since CSS Attributes are quite extensive, I have only addressed part of > it in this PR mainly CSS.Font properties.. Additional PR can be raised for > other attributes in due course.. It sounds reasonable but you have to update the bug summary to make it clear that this bug resolves the issue for `CSS.FontSize` only. The current bug subject suggests `CSS.CssValue` which is the super class of `CSS.FontSize` was fixed but it's not the case. Then, I think you should create a new bug for `CSS.CssValue` right away: we know _the problem exists_. Someone else may take it up. ------------- PR Comment: https://git.openjdk.org/jdk/pull/13405#issuecomment-1531375420
