On Fri, 28 Apr 2023 19:34:40 GMT, Erik Joelsson <er...@openjdk.org> wrote:
>> Jiangli Zhou has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Use $(JVM_LIBS), which includes -lrt on Linux currently. > > make/modules/java.desktop/lib/Awt2dLibraries.gmk line 228: > >> 226: # static libraries cause linking errors due to duplicate symbols. >> 227: LIBAWT_XAWT_STATIC_EXCLUDE_OBJS := \ >> 228: debug_assert.o debug_util.o debug_trace.o debug_mem.o >> systemScale.o > > Can this list be derived dynamically in some way? If they are all in the same > directory, maybe we could base it on that instead of having to maintain an > explicit list? With additional testing, I found 'debug_assert.o debug_util.o debug_trace.o debug_mem.o' are no longer included when building libawt_xawt, using JDK head code base. We no longer need to be filtered out those for libawt_xawt.a. They were needed for JDK 11. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13709#discussion_r1183201634
