On Tue, 2 May 2023 15:27:16 GMT, Alexey Ivanov <[email protected]> wrote:
>> Rajat Mahajan has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> code changes as per code review
>
> src/java.desktop/windows/native/libawt/windows/ThemeReader.cpp line 243:
>
>> 241: (JNIEnv* env, jclass klass, jstring widget, jint dpi) {
>> 242:
>> 243: LPCTSTR str = (LPCTSTR)JNU_GetStringPlatformChars(env, widget,
>> NULL);
>
> I'd rather keep the original formatting for casts as well as for `JNIEnv
> *env` in the declaration.
This isn't fully resolved: the space between the type and the expression should
be preserved on lines 243 and 254 (in the updated version).
LPCTSTR str = (LPCTSTR) JNU_GetStringPlatformChars(env, widget, NULL);
return (jlong) htheme;
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13701#discussion_r1220245608
