On Wed, 7 Jun 2023 04:44:44 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org>
wrote:
>> Alexander Zvegintsev has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - move screencast-tokens.properties to a new location
>> - fix failure of
>> javax/swing/reliability/HangDuringStaticInitialization.java in headless
>> environment
>
> src/java.desktop/unix/classes/sun/awt/X11/XRobotPeer.java line 53:
>
>> 51:
>> 52: tryGtk = Boolean.parseBoolean(
>> 53: AccessController.doPrivileged(
>
> Code formatting..better to align `AccessController `below `Boolean`
I moved a little, but with indent.
Compared to strictly under the Boolean, for my taste it is easier to quickly
parse with the eyes, and it does not visually merge.
> src/java.desktop/unix/classes/sun/awt/X11/XRobotPeer.java line 69:
>
>> 67: isOnWayland
>> 68: ? METHOD_SCREENCAST
>> 69: : METHOD_X11
>
> code alignment issue...will look better if all starts in same column
Same here.
> src/java.desktop/unix/native/libawt_xawt/awt/screencast_pipewire.c line 694:
>
>> 692: if ((*env)->ExceptionCheck(env)) {
>> 693: (*env)->ExceptionDescribe(env);
>> 694: (*env)->ExceptionClear(env);
>
> same here
Actually, these checks are not needed here at all, this is an oversight, there
was a Java function call before.
The check after ReleaseIntArrayElements is also unnecessary.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13803#discussion_r1221300355
PR Review Comment: https://git.openjdk.org/jdk/pull/13803#discussion_r1221300633
PR Review Comment: https://git.openjdk.org/jdk/pull/13803#discussion_r1221337758
