On Tue, 13 Jun 2023 18:13:12 GMT, Naoto Sato <na...@openjdk.org> wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert 'main.help.opt.any.file' value for _de
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler_de.properties
> line 140:
>
>> 138:
>> 139: # 0: type, 1: name
>> 140: compiler.err.annotation.unrecognized.attribute.name=Annotation @{0}
>> weist das unbekannte Attribut "{1}" auf
>
> Is it intentional to replace single quotes with double quotes? It is done in
> several locations in this file, but other languages keep using single quotes
> as in the source English resource file.
I will consult the language specialist on this. I remember in previous
discussions that certain languages would format punctuation differently, but
let ask about this specific instance.
> src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler_ja.properties
> line 959:
>
>> 957:
>> 958:
>> compiler.err.text.block.template.is.not.well.formed=\u30C6\u30AD\u30B9\u30C8\u30FB\u30D6\u30ED\u30C3\u30AF\u30FB\u30C6\u30F3\u30D7\u30EC\u30FC\u30C8\u304C\u6574\u5F62\u5F0F\u3067\u306F\u3042\u308A\u307E\u305B\u3093
>> 959:
>
> The translation of "well-formed" is incorrect. It is not 整数式
For translations that are incorrect, I can file a bug against the tool. Such a
fix would probably not happen soon, can you suggest an alternative for now?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14430#discussion_r1228567669
PR Review Comment: https://git.openjdk.org/jdk/pull/14430#discussion_r1228570665
